From 7a2ff64627b964710e3c19154482e7652388334f Mon Sep 17 00:00:00 2001 From: Eddie Dong Date: Thu, 9 Jun 2011 16:24:09 +0800 Subject: [PATCH] Nested VMX: Emulation of VMRESUME/VMLAUNCH Signed-off-by: Qing He Signed-off-by: Eddie Dong Acked-by: Tim Deegan Committed-by: Tim Deegan --- xen/arch/x86/hvm/vmx/vmx.c | 17 +++++++- xen/arch/x86/hvm/vmx/vvmx.c | 63 ++++++++++++++++++++++++++++++ xen/include/asm-x86/hvm/vmx/vvmx.h | 2 + 3 files changed, 80 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index 5b6a088b78..169a5ce0d1 100644 --- a/xen/arch/x86/hvm/vmx/vmx.c +++ b/xen/arch/x86/hvm/vmx/vmx.c @@ -2170,6 +2170,11 @@ asmlinkage void vmx_vmexit_handler(struct cpu_user_regs *regs) /* Now enable interrupts so it's safe to take locks. */ local_irq_enable(); + /* XXX: This looks ugly, but we need a mechanism to ensure + * any pending vmresume has really happened + */ + vcpu_nestedhvm(v).nv_vmswitch_in_progress = 0; + if ( unlikely(exit_reason & VMX_EXIT_REASONS_FAILED_VMENTRY) ) return vmx_failed_vmentry(exit_reason, regs); @@ -2464,10 +2469,18 @@ asmlinkage void vmx_vmexit_handler(struct cpu_user_regs *regs) update_guest_eip(); break; - case EXIT_REASON_MWAIT_INSTRUCTION: - case EXIT_REASON_MONITOR_INSTRUCTION: case EXIT_REASON_VMLAUNCH: + if ( nvmx_handle_vmlaunch(regs) == X86EMUL_OKAY ) + update_guest_eip(); + break; + case EXIT_REASON_VMRESUME: + if ( nvmx_handle_vmresume(regs) == X86EMUL_OKAY ) + update_guest_eip(); + break; + + case EXIT_REASON_MWAIT_INSTRUCTION: + case EXIT_REASON_MONITOR_INSTRUCTION: case EXIT_REASON_GETSEC: case EXIT_REASON_INVEPT: case EXIT_REASON_INVVPID: diff --git a/xen/arch/x86/hvm/vmx/vvmx.c b/xen/arch/x86/hvm/vmx/vvmx.c index d321c9e8f1..1847339631 100644 --- a/xen/arch/x86/hvm/vmx/vvmx.c +++ b/xen/arch/x86/hvm/vmx/vvmx.c @@ -261,6 +261,13 @@ static void reg_write(struct cpu_user_regs *regs, } } +static inline u32 __n2_exec_control(struct vcpu *v) +{ + struct nestedvcpu *nvcpu = &vcpu_nestedhvm(v); + + return __get_vvmcs(nvcpu->nv_vvmcx, CPU_BASED_VM_EXEC_CONTROL); +} + static int vmx_inst_check_privilege(struct cpu_user_regs *regs, int vmxop_check) { struct vcpu *v = current; @@ -486,6 +493,62 @@ int nvmx_handle_vmxoff(struct cpu_user_regs *regs) return X86EMUL_OKAY; } +int nvmx_vmresume(struct vcpu *v, struct cpu_user_regs *regs) +{ + struct nestedvmx *nvmx = &vcpu_2_nvmx(v); + struct nestedvcpu *nvcpu = &vcpu_nestedhvm(v); + int rc; + + rc = vmx_inst_check_privilege(regs, 0); + if ( rc != X86EMUL_OKAY ) + return rc; + + /* check VMCS is valid and IO BITMAP is set */ + if ( (nvcpu->nv_vvmcxaddr != VMCX_EADDR) && + ((nvmx->iobitmap[0] && nvmx->iobitmap[1]) || + !(__n2_exec_control(v) & CPU_BASED_ACTIVATE_IO_BITMAP) ) ) + nvcpu->nv_vmentry_pending = 1; + else + vmreturn(regs, VMFAIL_INVALID); + + return X86EMUL_OKAY; +} + +int nvmx_handle_vmresume(struct cpu_user_regs *regs) +{ + int launched; + struct vcpu *v = current; + + launched = __get_vvmcs(vcpu_nestedhvm(v).nv_vvmcx, + NVMX_LAUNCH_STATE); + if ( !launched ) { + vmreturn (regs, VMFAIL_VALID); + return X86EMUL_EXCEPTION; + } + return nvmx_vmresume(v,regs); +} + +int nvmx_handle_vmlaunch(struct cpu_user_regs *regs) +{ + int launched; + int rc; + struct vcpu *v = current; + + launched = __get_vvmcs(vcpu_nestedhvm(v).nv_vvmcx, + NVMX_LAUNCH_STATE); + if ( launched ) { + vmreturn (regs, VMFAIL_VALID); + rc = X86EMUL_EXCEPTION; + } + else { + rc = nvmx_vmresume(v,regs); + if ( rc == X86EMUL_OKAY ) + __set_vvmcs(vcpu_nestedhvm(v).nv_vvmcx, + NVMX_LAUNCH_STATE, 1); + } + return rc; +} + int nvmx_handle_vmptrld(struct cpu_user_regs *regs) { struct vcpu *v = current; diff --git a/xen/include/asm-x86/hvm/vmx/vvmx.h b/xen/include/asm-x86/hvm/vmx/vvmx.h index efc62e1f1c..35a184b320 100644 --- a/xen/include/asm-x86/hvm/vmx/vvmx.h +++ b/xen/include/asm-x86/hvm/vmx/vvmx.h @@ -158,6 +158,8 @@ int nvmx_handle_vmptrst(struct cpu_user_regs *regs); int nvmx_handle_vmclear(struct cpu_user_regs *regs); int nvmx_handle_vmread(struct cpu_user_regs *regs); int nvmx_handle_vmwrite(struct cpu_user_regs *regs); +int nvmx_handle_vmresume(struct cpu_user_regs *regs); +int nvmx_handle_vmlaunch(struct cpu_user_regs *regs); #endif /* __ASM_X86_HVM_VVMX_H__ */ -- 2.30.2